Skip to content

fix(vue-query): re-export core filter types - #11287

Open
spaansba wants to merge 1 commit into
TanStack:mainfrom
spaansba:fix/vue-query-filter-types
Open

fix(vue-query): re-export core filter types#11287
spaansba wants to merge 1 commit into
TanStack:mainfrom
spaansba:fix/vue-query-filter-types

Conversation

@spaansba

@spaansba spaansba commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@tanstack/vue-query currently shadows query-core’s QueryFilters and MutationFilters with Vue-specific reactive types. Wrapper libraries that type QueryClient operations such as removeQueries therefore cannot import the matching filters from the Vue package. This renames the Vue-specific types and restores the core exports.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ef90e02-1d96-44f1-ada1-95e355f5e7e8

📥 Commits

Reviewing files that changed from the base of the PR and between 84b4f13 and 3ccbd43.

📒 Files selected for processing (5)
  • .changeset/tidy-pandas-fetch.md
  • packages/vue-query/src/__tests__/filterTypes.test-d.ts
  • packages/vue-query/src/index.ts
  • packages/vue-query/src/useIsFetching.ts
  • packages/vue-query/src/useMutationState.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Vue Query updates query and mutation filter type exports. It adds Vue-specific filter aliases for reactive and callback inputs, aligns them with core filter types, and adds type-level tests and a patch changeset.

Changes

Vue Query filter types

Layer / File(s) Summary
Filter type aliases and hook signatures
packages/vue-query/src/useIsFetching.ts, packages/vue-query/src/useMutationState.ts		 useIsFetching and useIsMutating now use exported Vue-specific filter aliases. Mutation state options use the Vue-wrapped core MutationFilters type.
Public exports and type validation
packages/vue-query/src/index.ts, packages/vue-query/src/__tests__/filterTypes.test-d.ts, .changeset/tidy-pandas-fetch.md		 The package index exports the updated filter aliases. Type tests verify that query and mutation filter types match the corresponding core types. A patch changeset documents the export change.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 3ccbd

This PR re-exports core filter types from Vue Query and adds focused type coverage; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: tkdodo

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided. The required Changes, Checklist, and Release Impact sections are missing. Add a description that explains the changes and motivation, completes the checklist, and states the release impact. Confirm whether the changeset was generated for the published-code changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: correcting the vue-query public handling of core query and mutation filter types. It is concise and specific.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@spaansba